[Accessibility] Forces chart aria label to read only the title of the chart#178
Open
sakari-malkki wants to merge 2 commits into
Open
[Accessibility] Forces chart aria label to read only the title of the chart#178sakari-malkki wants to merge 2 commits into
sakari-malkki wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts Highcharts accessibility labeling so the chart container aria-label reads only the chart title, addressing the “Highcharts interactive chart” redundancy, and bumps the package version.
Changes:
- Adds
lang.accessibility.chartContainerLabeloverride in shared chart options. - Bumps npm package version from
1.4.8to1.4.9.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/core/chartOptions/chartOptions.ts | Overrides Highcharts accessibility chartContainerLabel to only announce the chart title. |
| package.json | Increments package version for the release containing the accessibility fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the "Highcharts interactive chart" aria label issue